Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix [Bug]: Yarra Ranges Council Error #2974 #2978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix [Bug]: Yarra Ranges Council Error #2974 #2978

wants to merge 1 commit into from
+7 −3

Conversation

ReneNulschDE
Copy link
Contributor

Fixed:

  • Test cases - Address structure has changed
  • Div selection

Testcases:

Testing source yarra_ranges_vic_gov_au ...
  found 3 entries for Petstock Lilydale
    2024-11-08 : FOGO
    2024-11-08 : Rubbish Collection
    2024-11-15 : Recycling Collection
  found 3 entries for Beechworth Bakery Healesville
    2024-11-05 : FOGO
    2024-11-12 : Rubbish Collection
    2024-11-05 : Recycling Collection

@Huskywatch
Copy link

When I attempt to set this up with the test addresses I get the same error:
image

And if I use an incorrect address (ie old format) I get the following error as expected:
The source returned an invalid response: "Address search for '316 Maroondah Hwy, Healesville VIC 3777' returned no results. Check your address on https://www.yarraranges.vic.gov.au/Environment/Waste/Find-your-waste-collection-and-burning-off-dates". Please check the provided arguments and try again.

@ReneNulschDE
Copy link
Contributor Author

@Huskywatch : Did you used the new code and restarted HA?

@Huskywatch
Copy link

Huskywatch commented Nov 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReneNulschDE @Huskywatch